This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix picture raster cache throttling #13710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we're also counting the pictures that are already raster cached. This fixes flutter/flutter#44252 and helps solving the GPU thread issue of flutter/flutter#43083
|
So the limit was 2 cached pictures period rather than 2 newly rasterized per frame. Good catch. |
flar
approved these changes
Nov 14, 2019
chinmaygarde
approved these changes
Nov 14, 2019
liyuqian
added a commit
to liyuqian/flutter
that referenced
this pull request
Nov 17, 2019
This will catch issues like flutter#44252, and this test is inspired by the `list_demo` sample app in flutter#43083 (comment) This is tested locally on a Moto G4 before and after the fix flutter/engine#13710 The `average_frame_rasterizer_time_millis` of this test drops from ~5.4ms to ~4.9ms after that fix.
|
@liyuqian I think GitHub closed this on you against your actual wishes because of how you worded the body of flutter/flutter@a32fc98? |
|
Ah yes. Thank you very much @dnfield ! |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 21, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Nov 21, 2019
git@github.com:flutter/engine.git/compare/7a77e3625dd1...a388398 git log 7a77e36..a388398 --no-merges --oneline 2019-11-21 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from VHWsK... to zgJ75... (flutter/engine#13957) 2019-11-21 bkonyi@google.com Roll src/third_party/dart 867a6e0e52..aa2b3a5eaa (15 commits) (flutter/engine#13955) 2019-11-21 30870216+gaaclarke@users.noreply.github.com Made the thread checker print out the thread names on Apple platforms. (flutter/engine#13943) 2019-11-21 liyuqian@google.com Fix picture raster cache throttling (flutter/engine#13710) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we're also counting the pictures that are already raster
cached.
This fixes flutter/flutter#44252 and helps
solving the GPU thread issue of flutter/flutter#43083
flutter/flutter#45050 is a performance test in the framework repo to reveal this bug.