This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Prevent default when Tab is clicked #12986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nturgut
reviewed
Oct 7, 2019
|
|
||
| default: | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Question: I don't know how custom shortcuts work very well. For example if a user/operating system defined a combination of keys as tab (for example F3 also works as tab), will this code still work?
There was a problem hiding this comment.
That will depend on how the OS is sending the event to the browser.
My guess is that the OS or the keyboard is doing the mapping and sending a Tab key event to the browser. For example, some keyboards have a Copy and Paste keys. So I attached a keydown event listener in the browser and clicked the Copy key in my keyboard. I got a ctrl then a c.
nturgut
approved these changes
Oct 7, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 8, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Oct 8, 2019
git@github.com:flutter/engine.git/compare/49dbaae818cd...3a445ed git log 49dbaae..3a445ed --no-merges --oneline 2019-10-08 30870216+gaaclarke@users.noreply.github.com Made _printDebug only happen on debug builds of the engine for now. (flutter/engine#12980) 2019-10-08 devoncarew@google.com remove references to package:_chrome (flutter/engine#12931) 2019-10-08 ditman@gmail.com Open source canvas tests from flutter_web_ui (flutter/engine#12819) 2019-10-08 mouad.debbar@gmail.com Prevent default when Tab is clicked (flutter/engine#12986) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
git@github.com:flutter/engine.git/compare/49dbaae818cd...3a445ed git log 49dbaae..3a445ed --no-merges --oneline 2019-10-08 30870216+gaaclarke@users.noreply.github.com Made _printDebug only happen on debug builds of the engine for now. (flutter/engine#12980) 2019-10-08 devoncarew@google.com remove references to package:_chrome (flutter/engine#12931) 2019-10-08 ditman@gmail.com Open source canvas tests from flutter_web_ui (flutter/engine#12819) 2019-10-08 mouad.debbar@gmail.com Prevent default when Tab is clicked (flutter/engine#12986) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hitting
Tabinside a text field messes up the focus in the browser. We should prevent default and let Flutter handle it.This PR also fixes a leak of
Keyboardinitialization across tests.Issue: flutter/flutter#41396