This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix C++ MethodChannel reply type #17607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes InvokeMethod's reply a high-level response object, rather than binary data, matching the abstraction level of the class (and the other languages' implementations). In support of that: - Adds the logic to the codecs to decode response envelopes, which had never been implemented. - Adds a convience implementation of MethodResult that forwards to lambdas, so that one-off invocation handlers are easier to write. Fixes flutter/flutter#53223
franciscojma86
approved these changes
Apr 9, 2020
shell/platform/common/cpp/client_wrapper/include/flutter/method_result_functions.h
Outdated
Show resolved
Hide resolved
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 12, 2020
goderbauer
pushed a commit
to goderbauer/engine
that referenced
this pull request
Apr 16, 2020
Makes InvokeMethod's reply a high-level response object, rather than binary data, matching the abstraction level of the class (and the other languages' implementations). In support of that: - Adds the logic to the codecs to decode response envelopes, which had never been implemented. - Adds a convience implementation of MethodResult that forwards to lambdas, so that one-off invocation handlers are easier to write. Also simplified BinaryMessenger's API so that subclasses only need to implement one version of Send, rather than two almost-identical versions. Fixes flutter/flutter#53223
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes InvokeMethod's reply a high-level response object, rather than
binary data, matching the abstraction level of the class (and the other
languages' implementations).
In support of that:
never been implemented.
lambdas, so that one-off invocation handlers are easier to write.
Also simplified BinaryMessenger's API so that subclasses only need to
implement one version of Send, rather than two almost-identical versions.
Fixes flutter/flutter#53223