This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Implement Gradient Shaders and Fragment Shaders in Skwasm #41144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahwilliams
approved these changes
Apr 13, 2023
Comment on lines
135
to
144
| Pointer<Float> convertDoublesToNative(Iterable<double> values) { | ||
| final Pointer<Float> pointer = allocFloatArray(values.length); | ||
| int i = 0; | ||
| for (final double value in values) { | ||
| pointer[i] = value; | ||
| i++; | ||
| } | ||
| return pointer; | ||
| } | ||
|
|
There was a problem hiding this comment.
Suggested change
| Pointer<Float> convertDoublesToNative(Iterable<double> values) { | |
| final Pointer<Float> pointer = allocFloatArray(values.length); | |
| int i = 0; | |
| for (final double value in values) { | |
| pointer[i] = value; | |
| i++; | |
| } | |
| return pointer; | |
| } | |
| Pointer<Float> convertDoublesToNative(List<double> values) { | |
| final Pointer<Float> pointer = allocFloatArray(values.length); | |
| for (int i = 0; i < values.length; i++) { | |
| pointer[i] = value; | |
| } | |
| return pointer; | |
| } | |
Comment on lines
208
to
213
| int i = 0; | ||
| for (final SkwasmShader shader in _childShaders!) { | ||
| childShaders[i] = shader.handle; | ||
| i++; | ||
| } | ||
| } |
There was a problem hiding this comment.
here and elsewhere, this pattern seems like the worst of both worlds - you still have all the bookkeeping of a for loop, but with no syntax help. And all the overhead of a for-of loop
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements gradient shaders (linear, radial, conical, and sweep) as well as custom fragment shaders in Skwasm.
Something is still up with the ShaderMask layer though, it doesn't quite render correctly on Skwasm.
Edit: fixed and it's rendering consistently with CanvasKit now.