Network: add a banner indicating when we are not logging network requests #9495
+110
−64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliette
requested changes
Oct 27, 2025
Member
elliette
left a comment
There was a problem hiding this comment.
Request to use a Card instead of BannerInfo
| } | ||
| } | ||
|
|
||
| class _NetworkLoggingPausedMessage extends BannerInfo { |
Member
There was a problem hiding this comment.
I don't know if we are getting much benefit from extending BannerInfo, since it's really designed to be used with the banner controller (that's why we have to pass in parameters that then aren't being used, like the key and dismissOnConnectionChanges)
Instead, I think we could simply display a Card widget here with the "Traffic recording..." text and no X button.
elliette
reviewed
Oct 27, 2025
| if (!_recording) | ||
| Padding( | ||
| padding: const EdgeInsets.only(top: intermediateSpacing), | ||
| child: Card( |
Member
There was a problem hiding this comment.
nit: pull Card into a separate StatelessWidget (e.g. RecordingPausedBanner) otherwise LGTM!
elliette
reviewed
Oct 27, 2025
|
|
||
| ## Network profiler updates | ||
|
|
||
| * Fixed layout of the "error count" badge in the tab name. |
Member
There was a problem hiding this comment.
Missed this for the other PRs - these should have a PR attached (see examples above in file). However, this can be addressed when we put together the release notes and not necessarily in this PR
elliette
approved these changes
Oct 27, 2025
srawlins
added a commit
that referenced
this pull request
Oct 28, 2025
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Oct 28, 2025
Cherry-picked commits in DevTools repo include: * flutter/devtools@1b39a2e "Add basic support for Flutter web applications served with -d web-server" flutter/devtools#9468 * flutter/devtools@fb4fa1f "Handle shortcuts for actions like copy/paste when embedded inside VS Code" flutter/devtools#9472 * flutter/devtools@cd14e27 "Fix position and width of "error count" badge in Network in app bar" flutter/devtools#9470 * flutter/devtools@6b9ba48 "Add a horizontal scrollbar to DevTools tables" flutter/devtools#9482 * flutter/devtools@1f8b3f5 "Disable screens not compatible with DWDS websocket mode" flutter/devtools#9481 * flutter/devtools@8a42447 "Table columns are resizable" flutter/devtools#9485 * flutter/devtools@5c0b17a "Network panel: disable Header ExpansionTiles when no data" flutter/devtools#9492 * flutter/devtools@0dbead1 "Network: add a banner indicating when we are not logging network requests" flutter/devtools#9495 Issue description: Users were unable to use various functions in the DevTools Network screen, including copy+paste, view requests, and view the request table when embedded in a small window. What is the fix: Various fixes are included for these user issues. Why cherry-pick: Users reported these issues in the user survey pre-dating Flutter 3.35; it is important for user trust to fix these in Flutter 3.38. Risk: Low, this fix only affects DevTools. Issue link(s): Dart-Code/Dart-Code#3488, flutter/devtools#7253, flutter/devtools#9435, flutter/devtools#8920, flutter/devtools#9465, flutter/devtools#9488, flutter/devtools#9464 Cherry-pick: flutter/devtools@v2.51.0...2.51.1 Change-Id: Iae696151778849fdb6faf6bf83a123f518fee77c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/458020 Reviewed-by: Devon Carew <devoncarew@google.com> Commit-Queue: Samuel Rawlins <srawlins@google.com> Reviewed-by: Elliott Brooks <elliottbrooks@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #9489. There's not much to say... it's displayed below the controls:
Definitely review this with ?w=1 in the URL.