这是indexloc提供的服务，不要输入任何密码
Skip to content

Don't assume footer is present in _ConsoleOutputState builder. #9342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 23, 2025
Merged

Don't assume footer is present in _ConsoleOutputState builder. #9342

merged 2 commits into from
Jul 23, 2025
+5 −4

Conversation

biggs0125
Copy link
Contributor

Resolves this errors:

Null check operator used on a null value
file:///b/s/w/ir/x/w/devtools/packages/devtools_app/lib/src/shared/console/console.dart 214:37 \| build
file:///b/s/w/ir/x/w/rc/flutter/packages/flutter/lib/src/widgets/framework.dart 5824:27 \| build
file:///b/s/w/ir/x/w/rc/flutter/packages/flutter/lib/src/widgets/framework.dart 5875:11 \| performRebuild
file:///b/s/w/ir/x/w/rc/flutter/packages/flutter/lib/src/widgets/framework.dart 5866:11 \| _firstBuild
file:///b/s/w/ir/x/w/rc/flutter/packages/flutter/lib/src/widgets/framework.dart 5692:5 \| mount

@biggs0125 biggs0125 requested a review from a team as a code owner July 23, 2025 02:24
@biggs0125 biggs0125 requested review from elliette and removed request for a team July 23, 2025 02:24
elliette
elliette reviewed Jul 23, 2025
View reviewed changes
@elliette
Copy link
Member

Thanks! One request but otherwise LGTM.

I think the test failures might be flakes, I'm re-running them to see.

@biggs0125 biggs0125 requested a review from elliette July 23, 2025 18:05
@biggs0125 biggs0125 merged commit 4347294 into flutter:master Jul 23, 2025
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elliette elliette elliette approved these changes

Assignees
No one assigned
Labels
release-notes-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@biggs0125 @elliette @natebiggs