Decrease ring buffer size to 2^31 - 1 which is wasm limit #9341
+6
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
elliette
approved these changes
Jul 23, 2025
elliette
reviewed
Jul 23, 2025
...vtools_app/lib/src/screens/performance/panes/timeline_events/timeline_events_controller.dart
Outdated
Show resolved
Hide resolved
elliette
approved these changes
Jul 23, 2025
|
Note: Failure is because timeline_events_controller needs to be formatted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wasm sets a hard limit of 2^31 - 1 bytes on Uint8Lists:
https://github.com/dart-lang/sdk/blob/main/sdk/lib/_internal/wasm/lib/typed_data.dart#L38
This is 1 more than the value that was previously specified here. When these buffers were reaching their max size this was causing a range check error: