Combine the pause and resume buttons in the debugger #9095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliette
approved these changes
Apr 3, 2025
bkonyi
approved these changes
Apr 4, 2025
| // Note: this could be refactored to use a single [GaDevToolsButton] instead | ||
| // of a [RoundedButtonGroup] with only one child, but this would require | ||
| // changes to the underlying [DevToolsButton] widget from | ||
| // package:devtools_app_shared to accept an `iconAsset` as a parameter. |
There was a problem hiding this comment.
Is this worth filing an issue for?
There was a problem hiding this comment.
I left a note instead of a TODO per our discussion at the DevExp kick off meeting. I think this would be an issue filed that never becomes important enough to address, so I opted to leave a note instead of filing an issue since addressing this is unimportant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4924. Lands the changes from #8858.