ServiceExtensionManager: return early... earlier #9287
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found two little opportunities to be null safe and theoretically avoid creating a local closure.
In the first, we create a local variable,
final mainIsolate
, and then create a large local closure,callExtension
. Then we check if that local variable isnull
, in order to return early. Moving that check, and one more, above the closure declaration adds three benefits: (1) the variable is promoted to be non-null, (2) the code reads a little easier, grouping these return early checks, and (3) we avoid creating the local closure when we don't need it, potentially saving memory.The second is very similar to the first.