[ Memory ] Remove getIsolate polling in memory chart update logic
#8209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repeatedly calling `getIsolate` results in variables currently in scope in the top frame of the isolate at the time of the request being assigned object IDs, inserting them into the VM service's object ID ring buffer. This keeps the objects alive until the buffer wraps around, which can cause OOM exceptions if the target application is repeatedly making large, temporary allocations that would otherwise be GC'd. The logic has been updated to rely on SentinelExceptions and the Isolate event stream to determine when an isolate is no longer relevant and should be removed from the memory chart statistics. Fixes flutter#8180
packages/devtools_app/lib/src/screens/memory/panes/chart/controller/memory_tracker.dart
Outdated
Show resolved
Hide resolved
kenzieschmoll
approved these changes
Aug 19, 2024
|
Also, please add a release note entry in NEXT_RELEASE_NOTES.md |
packages/devtools_app/lib/src/screens/memory/panes/chart/controller/memory_tracker.dart
Outdated
Show resolved
Hide resolved
kenzieschmoll
pushed a commit
that referenced
this pull request
Aug 27, 2024
…8209) Repeatedly calling `getIsolate` results in variables currently in scope in the top frame of the isolate at the time of the request being assigned object IDs, inserting them into the VM service's object ID ring buffer. This keeps the objects alive until the buffer wraps around, which can cause OOM exceptions if the target application is repeatedly making large, temporary allocations that would otherwise be GC'd. The logic has been updated to rely on SentinelExceptions and the Isolate event stream to determine when an isolate is no longer relevant and should be removed from the memory chart statistics. Fixes #8180
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repeatedly calling
getIsolateresults in variables currently in scope in the top frame of the isolate at the time of the request being assigned object IDs, inserting them into the VM service's object ID ring buffer. This keeps the objects alive until the buffer wraps around, which can cause OOM exceptions if the target application is repeatedly making large, temporary allocations that would otherwise be GC'd.The logic has been updated to rely on SentinelExceptions and the Isolate event stream to determine when an isolate is no longer relevant and should be removed from the memory chart statistics.
Fixes #8180