这是indexloc提供的服务，不要输入任何密码
Skip to content

Reland 2: Make LiveTestWidgetsFlutterBinding work with setSurfaceSize and live tests #86912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jul 27, 2021
Merged

Reland 2: Make LiveTestWidgetsFlutterBinding work with setSurfaceSize and live tests #86912

merged 12 commits into from
Jul 27, 2021

Conversation

dkwingsmt
Copy link
Contributor

@dkwingsmt dkwingsmt commented Jul 22, 2021 •
edited
Loading

Reland #86449

On top of the original PR, this PR stablized the golden tests with

LiveTestWidgetsFlutterBinding().framePolicy = LiveTestWidgetsFlutterBindingFramePolicy.onlyPumps;

And instead of InkWells, it uses a simple GestureRecognizer to record taps.

The initial frame is also removed.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

dkwingsmt added 2 commits July 21, 2021 16:21
@dkwingsmt
Revert "Revert "Make LiveTestWidgetsFlutterBinding work with setSurfa…
63d3ec3 
…ceSize and live tests (flutter#86449)" (flutter#86730)"

This reverts commit 8802e32.

Fix pointer

Trigger Build

Change test to gesture detector
@dkwingsmt
Merge remote-tracking branch 'upstream/master' into reland-2-set-surf…
1e5e479 
…ace-size-test-messages
@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Jul 22, 2021
@google-cla google-cla bot added the cla: yes label Jul 22, 2021
@skia-gold
Copy link

Gold has detected about 2 new digest(s) on patchset 3.
View them at https://flutter-gold.skia.org/cl/github/86912

@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #86912 at sha 1a057a3

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Jul 23, 2021
@skia-gold
Copy link

Gold has detected about 2 new digest(s) on patchset 4.
View them at https://flutter-gold.skia.org/cl/github/86912

@skia-gold
Copy link

Gold has detected about 6 new digest(s) on patchset 5.
View them at https://flutter-gold.skia.org/cl/github/86912

@skia-gold
Copy link

Gold has detected about 2 new digest(s) on patchset 6.
View them at https://flutter-gold.skia.org/cl/github/86912

@flutter-dashboard
Copy link

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #86912 at sha fbd1ba6

@skia-gold
Copy link

Gold has detected about 4 new digest(s) on patchset 7.
View them at https://flutter-gold.skia.org/cl/github/86912

@dkwingsmt
Copy link
Contributor Author

@Piinks I believe this PR's golden results should be stable, but still empty commits trigger untriaged changes. Is it expected?

@flutter-dashboard
Copy link

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #86912 at sha 049bf1d

@Piinks
Copy link
Contributor

Piinks commented Jul 23, 2021

If you triage the images, and then push an empty commit and it presents more, than yeah, it's still making new images.

Once images are triaged for a PR, if they come up again in a new commit on the PR, Gold won't need you to triage them if they are are the same images as before.

@skia-gold
Copy link

Gold has detected about 4 new digest(s) on patchset 8.
View them at https://flutter-gold.skia.org/cl/github/86912

@skia-gold
Copy link

Gold has detected about 4 new digest(s) on patchset 10.
View them at https://flutter-gold.skia.org/cl/github/86912

@dkwingsmt
Copy link
Contributor Author

@Piinks Ok this time the empty commit triggers notification but no untriaged digests. I think this means it's stable.

@skia-gold
Copy link

Gold has detected about 2 new digest(s) on patchset 11.
View them at https://flutter-gold.skia.org/cl/github/86912

@flutter-dashboard
Copy link

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #86912 at sha 71e186e

@dkwingsmt dkwingsmt requested a review from goderbauer July 27, 2021 03:18
@skia-gold
Copy link

Gold has detected about 4 new digest(s) on patchset 12.
View them at https://flutter-gold.skia.org/cl/github/86912

goderbauer
goderbauer approved these changes Jul 27, 2021
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit b50991d into flutter:master Jul 27, 2021
@dkwingsmt dkwingsmt deleted the reland-2-set-surface-size-test-messages branch July 28, 2021 22:22
dkwingsmt added a commit to dkwingsmt/flutter that referenced this pull request Jul 28, 2021
@dkwingsmt
Revert "Reland 2: Make LiveTestWidgetsFlutterBinding work with setSur…
bce3f54 
…faceSize and live tests (flutter#86912)"

This reverts commit b50991d.
@dkwingsmt dkwingsmt mentioned this pull request Jul 28, 2021
Merged
8 tasks
dkwingsmt added a commit that referenced this pull request Jul 28, 2021
@dkwingsmt
Revert "Reland 2: Make LiveTestWidgetsFlutterBinding work with setSur…
5b80d32 
…faceSize and live tests (#86912)" (#87233)

This reverts commit b50991d.
dkwingsmt added a commit to dkwingsmt/flutter that referenced this pull request Jul 29, 2021
@dkwingsmt
Revert "Revert "Reland 2: Make LiveTestWidgetsFlutterBinding work wit…
202522c 
…h setSurfaceSize and live tests (flutter#86912)" (flutter#87233)"

This reverts commit 5b80d32.
@dkwingsmt dkwingsmt mentioned this pull request Jul 29, 2021
Merged
8 tasks
dkwingsmt added a commit that referenced this pull request Jul 29, 2021
@dkwingsmt
Reland 3: Make LiveTestWidgetsFlutterBinding work with setSurfaceSize…
884158a 
… and live tests (#87239)

* Revert "Revert "Reland 2: Make LiveTestWidgetsFlutterBinding work with setSurfaceSize and live tests (#86912)" (#87233)"

This reverts commit 5b80d32.

* Record tap positions
@Piinks Piinks mentioned this pull request Aug 3, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees
No one assigned
Labels
a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. will affect goldens Changes to golden files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dkwingsmt @skia-gold @Piinks @goderbauer @fluttergithubbot