这是indexloc提供的服务,不要输入任何密码
Skip to content

Only stop search for upstream character if we hit a newline #86960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 26, 2021

Conversation

harryterkelsen
Copy link
Contributor

In some renderers (in particular, ones which use SkParagraph as the text renderer) the bounding box for a combining character will be empty. This causes the caret to be placed at the beginning of the text box if the last character in the text box has a combining character. This PR causes the text painter to keep searching for a grapheme with an actual bounding box

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Jul 23, 2021
@google-cla google-cla bot added the cla: yes label Jul 23, 2021
@harryterkelsen harryterkelsen requested a review from ferhatb July 23, 2021 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants