Only stop search for upstream character if we hit a newline #86960
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some renderers (in particular, ones which use SkParagraph as the text renderer) the bounding box for a combining character will be empty. This causes the caret to be placed at the beginning of the text box if the last character in the text box has a combining character. This PR causes the text painter to keep searching for a grapheme with an actual bounding box
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.