Fix an exception being thrown when focus groups are empty. #86734
Conversation
|
Gold has detected about 2 new digest(s) on patchset 1. |
| @@ -2015,6 +2015,11 @@ void main() { | |||
| expect(events.length, 2); | |||
| }); | |||
|
|
|||
| testWidgets('Focus traversal does not throw when no focusable is available in a group', (WidgetTester tester) async { | |||
| await tester.pumpWidget(const MaterialApp(home: Scaffold(body: ListTile(title: Text('title'))))); | |||
| await tester.sendKeyEvent(LogicalKeyboardKey.tab); | |||
There was a problem hiding this comment.
Can we assert somehow that "nothing" has focus or that the focus stayed where it was even after the tab was send?
|
Gold has detected about 4 new digest(s) on patchset 2. |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Description
When a focus traversal group has no entries, but traversal is requested, we were throwing an exception because we couldn't find the group marker's scope in the list of candidates. This fixes that, and adds a test.
Related Issues
FocusTraversalPolicy._sortAllDescendantscrashes/throws error when tab to focus on unfocusable widgets #86706Tests