这是indexloc提供的服务，不要输入任何密码
Skip to content

[flutter_releases] Fix dartdocs branch name on 2.2.x #86723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 24, 2021
Merged

[flutter_releases] Fix dartdocs branch name on 2.2.x #86723

merged 3 commits into from
Jul 24, 2021

Conversation

christopherfujino
Copy link
Contributor

@christopherfujino christopherfujino commented Jul 20, 2021 •
edited
Loading

cherrypick of teach dartdoc.dart about LUCI_BRANCH env var (#86592)

will fix #77178 and #86297 on stable.

NOTE: this will not be deployed until the next stable hotfix.

@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Jul 20, 2021
@google-cla google-cla bot added the cla: yes label Jul 20, 2021
@skia-gold
Copy link

Gold has detected about 3 new digest(s) on patchset 1.
View them at https://flutter-gold.skia.org/cl/github/86723

@christopherfujino
Copy link
Contributor Author

Analysis failing because it looks like this code is running in pre-null-safe dart mode on this branch. I will have to fix.

@christopherfujino christopherfujino marked this pull request as draft July 20, 2021 17:51
@christopherfujino christopherfujino marked this pull request as ready for review July 20, 2021 19:49
@skia-gold
Copy link

Gold has detected about 1 new digest(s) on patchset 2.
View them at https://flutter-gold.skia.org/cl/github/86723

@skia-gold
Copy link

Gold has detected about 6 new digest(s) on patchset 3.
View them at https://flutter-gold.skia.org/cl/github/86723

@christopherfujino
Copy link
Contributor Author

docs CI build green: https://ci.chromium.org/p/flutter/builders/try/Linux%20docs/14726?

@christopherfujino christopherfujino mentioned this pull request Jul 20, 2021
Closed
@christopherfujino
Copy link
Contributor Author

ping @gspencergoog

gspencergoog
gspencergoog approved these changes Jul 24, 2021
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

Sorry, I thought I already LGTM'd this one.

@christopherfujino christopherfujino merged commit 07d2f6f into flutter:flutter-2.2-candidate.10 Jul 24, 2021
@christopherfujino christopherfujino deleted the flutter-2.2-candidate.10 branch July 24, 2021 01:53
@christopherfujino christopherfujino mentioned this pull request Nov 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees
No one assigned
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christopherfujino @skia-gold @gspencergoog