In xcode_backend.sh, build flutter assemble arguments as an array of quoted strings #86534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
reviewed
Jul 16, 2021
There was a problem hiding this comment.
Does this fail on master and pass on this PR if you change this:
to:
'--split-debug-info=foo with space/',Adding a --dart-define= with spaces would also be a way to test this (and expand coverage).
macOS has the same issue:
https://github.com/flutter/flutter/blob/master/packages/flutter_tools/bin/macos_assemble.sh
tested in:
jmagman
reviewed
Jul 16, 2021
They're there in the |
jmagman
approved these changes
Jul 16, 2021
There was a problem hiding this comment.
Huh I'm surprised nothing complained about checking in those app_icon_*.png binaries.
They're there in the
ios/subdir as well.
I noticed that, I was surprised by that too!
The build test on the new macos project passed:
▌16:45:03▐ RUNNING: cd examples/hello_world; ../../bin/flutter build macos --debug -v
| expect(result.exitCode, 0); | ||
| }, skip: true); // Extremely flaky due to https://github.com/flutter/flutter/issues/68144 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, some arguments such as
--sksl-bundle-pathare passed toflutter assemblewithout quotes such that a path with a space in it would be interpreted as two separate command line arguments, leading to various errors.This PR assembles the argument array as a bash array of quoted strings, which makes it easier to conditionally add some arguments while ensuring that they are properly quoted.
This will help the benchmarks added in #86460 get closer to running.