这是indexloc提供的服务，不要输入任何密码
Skip to content

Add textDirection property to CupertinoTextField and CupertinoTextFormFieldRow #86482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2021
Merged

Add textDirection property to CupertinoTextField and CupertinoTextFormFieldRow #86482

merged 1 commit into from
Jul 16, 2021

Conversation

bryanoltman
Copy link
Contributor

@bryanoltman bryanoltman commented Jul 15, 2021 •
edited
Loading

Adds an optional textDirection parameter to the CupertinoTextField and CupertinoTextFormFieldRow constructors for parity with the Material TextField and TextFormField classes. The textDirection provided is simply forwarded to the wrapped EditableText.

Fixes #85330

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

@bryanoltman bryanoltman requested a review from a14n July 15, 2021 15:13
@flutter-dashboard flutter-dashboard bot added f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels. labels Jul 15, 2021
@google-cla google-cla bot added the cla: yes label Jul 15, 2021
@bryanoltman bryanoltman requested a review from xster July 15, 2021 17:58
LongCatIsLooong
LongCatIsLooong approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@LongCatIsLooong LongCatIsLooong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for contributing!

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Mac framework_tests_misc has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot merged commit 68fb008 into flutter:master Jul 16, 2021
@bryanoltman bryanoltman deleted the text-direction-85330 branch July 16, 2021 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xster xster xster approved these changes

@LongCatIsLooong LongCatIsLooong LongCatIsLooong approved these changes

@a14n a14n Awaiting requested review from a14n

Assignees
No one assigned
Labels
f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CupertinoTextField and CupertinoFormRow don't have textDirection
4 participants
@bryanoltman @fluttergithubbot @xster @LongCatIsLooong