这是indexloc提供的服务，不要输入任何密码
Skip to content

Fixed a cast issue with host_mode_tests.dart. #86392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2021
Merged

Fixed a cast issue with host_mode_tests.dart. #86392

merged 1 commit into from
Jul 14, 2021

Conversation

darrenaustin
Copy link
Contributor

This should fix a cast failure for some device lab tests:

Task result:
{
  "success": false,
  "reason": "Task failed: type '_InternalLinkedHashMap<String, dynamic>' is not a subtype of type 'Map<String, Object>' in type cast"
}

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Jul 14, 2021
@google-cla google-cla bot added the cla: yes label Jul 14, 2021
@darrenaustin
Copy link
Contributor Author

@jonahwilliams I think this should fix the build breakage that hit on your checkin above mine, can you give this a quick review?

@Hixie
Copy link
Contributor

Hixie commented Jul 14, 2021

test-exempt: is a test

jmagman
jmagman approved these changes Jul 14, 2021
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dynamic or Object?, we're not consistent. LGTM

@darrenaustin darrenaustin merged commit 4c96cb2 into flutter:master Jul 14, 2021
@darrenaustin
Copy link
Contributor Author

dynamic or Object?, we're not consistent. LGTM

Yeah, dealing with json is messy. I think I had tried to convert everything here to Object, but it wasn't feasible, so I reverted it back, but this part was somehow missed. My apologies. Thanks for the quick review.

@darrenaustin darrenaustin deleted the devicelab_hot_test branch July 23, 2021 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmagman jmagman jmagman approved these changes

@jonahwilliams jonahwilliams Awaiting requested review from jonahwilliams

Assignees
No one assigned
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@darrenaustin @Hixie @jmagman