这是indexloc提供的服务,不要输入任何密码
Skip to content

Migrate devicelab framework code to null safety. #86325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2021
Merged

Migrate devicelab framework code to null safety. #86325

merged 1 commit into from
Jul 13, 2021

Conversation

darrenaustin
Copy link
Contributor

Attempt to reland #85993.

Part of #84014.

This migrates the core framework parts of the devicelab code. It doesn't turn on sound null safety for running the tasks yet. It just allows other parts of the devicelab code to run with null safety when they are migrated.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Jul 12, 2021
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@Hixie
Copy link
Contributor

Hixie commented Jul 12, 2021

test-exempt: refactor with no semantic change

Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darrenaustin darrenaustin added a: null-safety Support for Dart's null safety feature waiting for tree to go green labels Jul 13, 2021
@darrenaustin darrenaustin merged commit ef5ffd0 into flutter:master Jul 13, 2021
@darrenaustin darrenaustin deleted the null_devicelab_core branch July 23, 2021 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: null-safety Support for Dart's null safety feature c: contributor-productivity Team-specific productivity, code health, technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants