Fix analysis script to run from anywhere #86683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c21fc3a to
96f2d20
Compare
craiglabenz
approved these changes
Jul 19, 2021
|
Oh goodie, a Windows-only error. |
96f2d20 to
f6acf9f
Compare
dnfield
reviewed
Jul 20, 2021
| print('Expected output $type'); | ||
| } | ||
| '''); | ||
| } |
There was a problem hiding this comment.
nit: newlines at EOF here and below
There was a problem hiding this comment.
Fixed, thanks.
f6acf9f to
0b2e8b5
Compare
0b2e8b5 to
1f1f64d
Compare
craiglabenz
reviewed
Jul 22, 2021
| @@ -38,7 +38,8 @@ Future<String> capture(AsyncVoidCallback callback, { int exitCode = 0 }) async { | |||
|
|
|||
| void main() { | |||
| final String testRootPath = path.join('test', 'analyze-test-input', 'root'); | |||
| final String dartPath = path.canonicalize(path.join('..', '..', 'bin', 'cache', 'dart-sdk', 'bin', Platform.isWindows ? 'dart.exe' : 'dart')); | |||
| final String dartName = Platform.isWindows ? 'dart.exe' : 'dart'; | |||
There was a problem hiding this comment.
the .exe extension on Windows always trips me up 😆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a small problem with the analyze.dart script that fixes it so that it can be invoked from any directory, not just the Flutter root.
Tests