这是indexloc提供的服务，不要输入任何密码
Skip to content

Fix EditableText when a controller listener changes values #85956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 6, 2021
Merged

Fix EditableText when a controller listener changes values #85956

merged 1 commit into from
Jul 6, 2021

Conversation

asashour
Copy link
Contributor

@asashour asashour commented Jul 6, 2021

Fixes #85876
Fixes #85882

When a listener of a controller changes the text and/or selection, EditableText should consider those changes.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Jul 6, 2021
@google-cla google-cla bot added the cla: yes label Jul 6, 2021
LongCatIsLooong
LongCatIsLooong approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@LongCatIsLooong LongCatIsLooong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@LongCatIsLooong
Copy link
Contributor

Could you try updating the branch to the tip of the tree to resolve the CI failure?

@asashour
Copy link
Contributor Author

asashour commented Jul 6, 2021

Thanks for the fix!

You are most welcome, thanks a lot for the speedy review.

@fluttergithubbot fluttergithubbot merged commit 210f6f8 into flutter:master Jul 6, 2021
@asashour asashour deleted the 85876 branch July 6, 2021 21:04
@SecareLupus SecareLupus mentioned this pull request Jan 2, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LongCatIsLooong LongCatIsLooong LongCatIsLooong approved these changes

Assignees
No one assigned
Labels
framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TextField setting textSelection fails when new text is shorter than original text TextField TextSelection position is not right
3 participants
@asashour @LongCatIsLooong @fluttergithubbot