这是indexloc提供的服务，不要输入任何密码
Skip to content

Assert disposed layers are not reused #85798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2021
Merged

Assert disposed layers are not reused #85798

merged 1 commit into from
Jul 7, 2021

Conversation

dnfield
Copy link
Contributor

@dnfield dnfield commented Jul 2, 2021

Fixes #85066

Must not be landed before cl/382767924

@dnfield dnfield requested review from yjbanov, goderbauer and ds84182 July 2, 2021 20:09
@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Jul 2, 2021
@google-cla google-cla bot added the cla: yes label Jul 2, 2021
yjbanov
yjbanov approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

goderbauer
goderbauer approved these changes Jul 7, 2021
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnfield
Copy link
Contributor Author

dnfield commented Jul 7, 2021

Internal CL is being submitted now. This should be good to go.

@fluttergithubbot fluttergithubbot merged commit 4d9a375 into flutter:master Jul 7, 2021
@dnfield dnfield deleted the assert_disposed branch July 7, 2021 21:45
@tvolkert tvolkert mentioned this pull request Aug 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yjbanov yjbanov yjbanov approved these changes

@goderbauer goderbauer goderbauer approved these changes

@ds84182 ds84182 Awaiting requested review from ds84182

Assignees
No one assigned
Labels
framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Assert that disposed layers are not re-used
4 participants
@dnfield @yjbanov @goderbauer @fluttergithubbot