这是indexloc提供的服务，不要输入任何密码
Skip to content

[flutter_tools] Add support for launching fuchsia app using session_control #85752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 12, 2021
Merged

[flutter_tools] Add support for launching fuchsia app using session_control #85752

merged 9 commits into from
Jul 12, 2021

Conversation

michaellee8
Copy link
Contributor

Allows fluttter app to be launched with session_control rather than tiles_ctl if such fuchsia build uses session_framework.

Further work on #83609. Refactored from #85450

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jul 2, 2021
@google-cla google-cla bot added the cla: yes label Jul 2, 2021
@michaellee8 michaellee8 mentioned this pull request Jul 2, 2021
Closed
8 tasks
@michaellee8 michaellee8 changed the title feat: add support for launching fuchsia app using session_control [flutter_tools] Add support for launching fuchsia app using session_control Jul 2, 2021
@michaellee8
Copy link
Contributor Author

@zanderso @chaselatta I have factored out the changes related to session_control in #85450 into this PR. Please review. This should be merged before #85450.

chaselatta
chaselatta requested changes Jul 2, 2021
View reviewed changes
@michaellee8 michaellee8 requested a review from chaselatta July 3, 2021 06:20
@michaellee8
Copy link
Contributor Author

@chaselatta Please review if there are any more problems.

@michaellee8
Copy link
Contributor Author

@chaselatta Can you have a look at this? Thx.

zanderso
zanderso reviewed Jul 9, 2021
View reviewed changes
chaselatta
chaselatta approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@chaselatta chaselatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once Zach's comments are addressed.

@michaellee8
Copy link
Contributor Author

I cannot understand why the CI fails on customer test. Did they changed ci config?

@fluttergithubbot fluttergithubbot merged commit 6a51e0c into flutter:master Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaselatta chaselatta chaselatta approved these changes

@zanderso zanderso zanderso approved these changes

Assignees
No one assigned
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michaellee8 @chaselatta @zanderso @fluttergithubbot