[flutter_tools] switch web integration tests to use html #85325
Conversation
|
It looks like the html version of the hot restart test is failing with a timeout in the presubmit checks. |
|
gosh darn it |
If it fails more consistently now, that is progress. |
|
Yup, fairly consistent now - at least I can debug this locally! |
|
these tests should be passing now, besides customer tests being broken |
|
@zanderso PTAL |
| runApp(MyApp()); | ||
| // See https://github.com/flutter/flutter/issues/86202 | ||
| if (kIsWeb) { | ||
| while (true) { |
|
|
||
| void main() async { | ||
| WidgetsFlutterBinding.ensureInitialized(); | ||
| final ByteData message = const StringCodec().encodeMessage('AppLifecycleState.resumed')!; | ||
| await ServicesBinding.instance!.defaultBinaryMessenger.handlePlatformMessage('flutter/lifecycle', message, (_) { }); | ||
| runApp(MyApp()); | ||
| // See https://github.com/flutter/flutter/issues/86202 |
There was a problem hiding this comment.
To make sure I understand, the solution to prints getting dropped that is being used here is to just call runApp repeatedly? When does it stop?
There was a problem hiding this comment.
yeah, run app causes a rebuild which triggers more prints. It stops when the app is stopped
| @@ -170,8 +170,7 @@ void main() { | |||
| await startPaused(expressionEvaluation: true); | |||
| await evaluateComplexExpressionsInLibrary(flutter); | |||
| }); | |||
| }, skip: true, // Flaky tests: https://github.com/flutter/flutter/issues/84012 | |||
| ); | |||
| }); | |||
There was a problem hiding this comment.
is it possible to unskip the other test as well (line 107 above)?
| @@ -27,7 +27,7 @@ void main() { | |||
|
|
|||
| await flutter.run( | |||
| withDebugger: true, startPaused: true, chrome: true, | |||
| additionalCommandArgs: <String>['--verbose']); | |||
| additionalCommandArgs: <String>['--verbose', '--web-renderer=html']); | |||
There was a problem hiding this comment.
can we unskip the test on line 51?
| @@ -32,7 +32,7 @@ void main() { | |||
| }); | |||
|
|
|||
| testWithoutContext('hot restart works without error', () async { | |||
| await flutter.run(chrome: true, additionalCommandArgs: <String>['--verbose']); | |||
| await flutter.run(chrome: true, additionalCommandArgs: <String>['--verbose', '--web-renderer=html']); | |||
There was a problem hiding this comment.
can we unskip the tests on lines 54 and 73?
|
Lets see how the other skipped tests do |
canvaskit is pulled from the net and may require more work than html for these test bots
Need to add loops because of #86202