这是indexloc提供的服务,不要输入任何密码
Skip to content

Update GestureDetector docs to use DartPad sample #85148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 24, 2021

Conversation

gspencergoog
Copy link
Contributor

Description

This removes the broken video for GestureDetector, and replaces it with a Dartpad sample, for both samples in GestureDetector.

Related Issues

Tests

  • Just a doc change, no tests.

@gspencergoog gspencergoog requested a review from dkwingsmt June 23, 2021 18:30
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Jun 23, 2021
@google-cla google-cla bot added the cla: yes label Jun 23, 2021
@Hixie
Copy link
Contributor

Hixie commented Jun 23, 2021

test-exempt: only affects comments

@Piinks Piinks added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation f: gestures flutter/packages/flutter/gestures repository. labels Jun 23, 2021
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM!

Co-authored-by: Kate Lovett <katelovett@google.com>
@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite luci-flutter has failed. Please fix the issues identified (or deflake) before re-applying this label.

@gspencergoog gspencergoog merged commit dff703f into flutter:master Jun 24, 2021
@gspencergoog gspencergoog deleted the gesture_detector_sample branch June 24, 2021 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: gestures flutter/packages/flutter/gestures repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GestureDetector docs: video probably incorrect
4 participants