这是indexloc提供的服务，不要输入任何密码
Skip to content

Avoid iOS app with extension checks that fail on M1 ARM Macs #85087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2021
Merged

Avoid iOS app with extension checks that fail on M1 ARM Macs #85087

merged 1 commit into from
Jun 23, 2021

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Jun 23, 2021

Xcode has slightly different build settings for an iOS app with a watch companion on an ARM Mac than on x86_64 Mac. The simulator is already being validated by running unit tests, so stick with validating architectures for physical devices.

Fixes #82402

@jmagman jmagman added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Jun 23, 2021
@jmagman jmagman self-assigned this Jun 23, 2021
@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Jun 23, 2021
@google-cla google-cla bot added the cla: yes label Jun 23, 2021
@jmagman jmagman changed the title Avoid iOS app with extension checks that fail on M1 Avoid iOS app with extension checks that fail on M1 ARM Macs Jun 23, 2021
@jmagman jmagman mentioned this pull request Jun 23, 2021
Closed
jonahwilliams
jonahwilliams approved these changes Jun 23, 2021
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit 67aee9a into flutter:master Jun 23, 2021
@jmagman jmagman deleted the extension-arm branch June 23, 2021 17:25
@jmagman jmagman added the platform-host-arm Building on an ARM-based platform label Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonahwilliams jonahwilliams jonahwilliams approved these changes

@christopherfujino christopherfujino Awaiting requested review from christopherfujino

Assignees

@jmagman jmagman

Labels
c: contributor-productivity Team-specific productivity, code health, technical debt. platform-host-arm Building on an ARM-based platform platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ios_app_with_extensions_test fails on ARM M1 mac
3 participants
@jmagman @jonahwilliams @fluttergithubbot