这是indexloc提供的服务，不要输入任何密码
Skip to content

[docs] Add TileMode.decal images #85024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 23, 2021
Merged

[docs] Add TileMode.decal images #85024

merged 3 commits into from
Jun 23, 2021

Conversation

werainkhatri
Copy link
Member

Added TileMode.decal images to LinearGradient and RadialGradient.

fixes #84837

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Jun 22, 2021
@google-cla google-cla bot added the cla: yes label Jun 22, 2021
@Piinks Piinks added a: quality A truly polished experience d: api docs Issues with https://api.flutter.dev/ documentation labels Jun 23, 2021
Piinks
Piinks approved these changes Jun 23, 2021
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution! Rebasing with master should resolve the infra issue affecting these checks. Also, @Hixie will need to grant test exemption.

@Hixie
Copy link
Contributor

Hixie commented Jun 23, 2021

test-exempt: only affects comments

Thanks for fixing these! You rock!

@fluttergithubbot fluttergithubbot merged commit 568f135 into flutter:master Jun 23, 2021
@werainkhatri werainkhatri deleted the decal-images branch June 24, 2021 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Piinks Piinks Piinks approved these changes

Assignees
No one assigned
Labels
a: quality A truly polished experience d: api docs Issues with https://api.flutter.dev/ framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TileMode images missing in API docs
4 participants
@werainkhatri @Hixie @Piinks @fluttergithubbot