fix _owner nullability in routers.dart
#84840
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
routers.dartrouters.dart
routers.dart_owner nullability in routers.dart
There was a problem hiding this comment.
Hi @TahaTesser thanks for the fix! This should have a test. Also, can you rebase your branch? That should resolve the failing checks from an infra issue.
|
(triage) Would you like to continue with this change @TahaTesser ? |
|
@Piinks |
…_owner_nullability
… into fix_owner_nullability
|
@Piinks Thank you so much for the review |
|
Gold has detected about 1 new digest(s) on patchset 8. |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
|
||
| await tester.pump(); |
There was a problem hiding this comment.
nit: revert this change here? This line belongs to the comment above and there shouldn't be a blank line in between.
| @@ -1712,6 +1712,25 @@ void main() { | |||
| await tester.pump(); | |||
| expect(tester.takeException(), null); | |||
| }); | |||
| testWidgets('child with no local history can be disposed', (WidgetTester tester) async { | |||
There was a problem hiding this comment.
nit: add a blank line before this one.
| final WidgetWithNoLocalHistoryState state = tester.state(find.byType(WidgetWithNoLocalHistory)); | ||
| state.addLocalHistory(); | ||
| // Waits for modal route to update its internal state; | ||
|
|
There was a problem hiding this comment.
nit: remove this blank line or place it before the comment
|
@goderbauer |
fixes #84769
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.