这是indexloc提供的服务，不要输入任何密码
Skip to content

Remove stripping scriptCodes for localization. #83903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 16, 2021
Merged

Remove stripping scriptCodes for localization. #83903

merged 3 commits into from
Jun 16, 2021

Conversation

greymag
Copy link
Contributor

@greymag greymag commented Jun 3, 2021

Remove stripping scriptCodes from locales when load date format information.

Issue #81905

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • [ x I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@greymag
Remove stripping scriptCodes for localization.
02b5c39 
Add tests for Serbian and Latin Serbian.
See #81905
@flutter-dashboard flutter-dashboard bot added a: internationalization Supporting other languages or locales. (aka i18n) f: material design flutter/packages/flutter/material repository. labels Jun 3, 2021
@google-cla google-cla bot added the cla: yes label Jun 3, 2021
shihaohong
shihaohong approved these changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@shihaohong shihaohong left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I wonder why we even stripped scriptCode in the first place

@fluttergithubbot fluttergithubbot merged commit f8d73be into flutter:master Jun 16, 2021
@greymag greymag mentioned this pull request Nov 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shihaohong shihaohong shihaohong approved these changes

Assignees
No one assigned
Labels
a: internationalization Supporting other languages or locales. (aka i18n) f: material design flutter/packages/flutter/material repository.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@greymag @shihaohong @fluttergithubbot