Remove logic to save artifacts to old gcs location. #83526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to finalize the process of the bucket migration to a new location. Bug: #75363
christopherfujino
approved these changes
May 28, 2021
dev/bots/prepare_package.dart
Outdated
| 'File $destGsPath already exists on cloud storage!', | ||
| ); | ||
| } | ||
| //final String releaseFolder = gsReleaseFolder; |
dev/bots/prepare_package.dart
Outdated
| final String tmpBaseUrl = newBucket ? newBaseUrl : oldBaseUrl; | ||
| jsonData['base_url'] = '$tmpBaseUrl$releaseFolder'; | ||
| Future<Map<String, dynamic>> _addRelease(Map<String, dynamic> jsonData) async { | ||
| //final String tmpBaseUrl = baseUrl; |
This was referenced Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to finalize the process of the bucket migration to a new
location.
Bug: #75363
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.