[web] Make web integration tests shadow DOM aware. #82926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ditman
commented
May 19, 2021
dev/integration_tests/web_e2e_tests/test_driver/text_editing_integration.dart
Outdated
Show resolved
Hide resolved
|
|
||
| // Press and release CapsLock. | ||
| dispatchKeyboardEvent(input, 'keydown', <String, dynamic>{ | ||
| 'key': 'CapsLock', | ||
| 'code': 'CapsLock', | ||
| 'bubbles': true, | ||
| 'cancelable': true, | ||
| 'composed': true, |
There was a problem hiding this comment.
composed needs to be set to true in synthetic events (similar to bubbles) so the event propagates in a similar way as to when it's dispatched by the browser. Docs.
ditman
commented
May 19, 2021
|
(This needs a rebase, to land after #82939) |
9 tasks
|
This pull request is not suitable for automatic merging in its current state.
|
ditman
commented
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new version of the web engine changes the markup of Flutter Web apps to render them inside the ShadowDOM of the
flt-glass-panetag.This PR changes the flutter framework engine integration tests so they are backwards (and forwards) compatible with both DOM styles.
Issues
Waiting for: FlutterDriver: deprecate enableAccessibility; redirect it to setSemantics; add setSemantics tests #82939Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.