这是indexloc提供的服务,不要输入任何密码
Skip to content

Drag gesture recognizer accepts all pointers when any pointer is accepted #82786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dkwingsmt
Copy link
Contributor

@dkwingsmt dkwingsmt commented May 18, 2021

Drag gesture recognizer now accepts all pointers when any pointer is accepted. This is useful when the accepted pointer is accepted by default, i.e. when all other arena memebers has quit (been disposed).

Fixes #82784.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label May 18, 2021
@google-cla google-cla bot added the cla: yes label May 18, 2021
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for hunting that down! 👍

tap.dispose();

// Wait for microtasks to finish, during which drag claims victory.
tester.async.elapse(const Duration(milliseconds: 1));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tester.async.flushMicrotasks() ? Or do you actually need time to pass?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drag gesture crashes when one of the 2 pointers wins by default and is then released
3 participants