这是indexloc提供的服务，不要输入任何密码
Skip to content

added gaaclarke as testowner for platform channels benchmarks #82756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2021
Merged

added gaaclarke as testowner for platform channels benchmarks #82756

merged 1 commit into from
May 19, 2021

Conversation

gaaclarke
Copy link
Member

issue: #82743

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gaaclarke gaaclarke requested a review from keyonghan May 17, 2021 22:13
@google-cla google-cla bot added the cla: yes label May 17, 2021
@gaaclarke gaaclarke changed the title added myself as testowner for platform channels benchmarks added gaaclarke as testowner for platform channels benchmarks May 17, 2021
goderbauer
goderbauer approved these changes May 19, 2021
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer goderbauer added the c: contributor-productivity Team-specific productivity, code health, technical debt. label May 19, 2021
keyonghan
keyonghan reviewed May 19, 2021
View reviewed changes
TESTOWNERS
@@ -50,6 +50,7 @@
/dev/devicelab/bin/tasks/multi_widget_construction_perf__e2e_summary.dart @zanderso @flutter/engine
/dev/devicelab/bin/tasks/new_gallery__crane_perf.dart @zanderso @flutter/engine
/dev/devicelab/bin/tasks/picture_cache_perf__e2e_summary.dart @zanderso @flutter/engine
/dev/devicelab/bin/tasks/platform_channels_benchmarks @gaaclarke @flutter/engine
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: missed .dart

TESTOWNERS
@@ -137,6 +138,7 @@
/dev/devicelab/bin/tasks/new_gallery_ios__transition_perf.dart @zanderso @flutter/engine
/dev/devicelab/bin/tasks/platform_channel_sample_test_ios.dart @zanderso @flutter/engine
/dev/devicelab/bin/tasks/platform_channel_sample_test_swift.dart @zanderso @flutter/engine
/dev/devicelab/bin/tasks/platform_channels_benchmarks_ios @gaaclarke @flutter/engine
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto.

@fluttergithubbot fluttergithubbot merged commit 0c5f2f4 into flutter:master May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keyonghan keyonghan keyonghan left review comments

@goderbauer goderbauer goderbauer approved these changes

Assignees
No one assigned
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gaaclarke @goderbauer @keyonghan @fluttergithubbot