Add cmdline tools to docker image. #82584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to make the flutter doctor new checks to pass. Bug: #82565
christopherfujino
approved these changes
May 15, 2021
There was a problem hiding this comment.
LGTM, docker image built and licenses accepted. Not sure about the web smoke test failure:
flutter drive --target=test_driver/smoke_web_engine.dart -d web-server --profile --browser-name=chrome
Downloading Web SDK... 2,539ms
Running "flutter pub get" in hello_world... 1,199ms
Launching test_driver/smoke_web_engine.dart on Web Server in profile mode...
Compiling test_driver/smoke_web_engine.dart for the Web... 29.6s
test_driver/smoke_web_engine.dart is being served at http://localhost:44383
The web-server device requires the Dart Debug Chrome extension for debugging. Consider using the Chrome or Edge devices for an improved development workflow.
Application finished.
Unable to start WebDriver Session for Flutter for Web testing.
Make sure you have the correct WebDriver Server running at 4444.
Make sure the WebDriver Server matches option --browser-name.
SocketException: OS Error: Connection refused, errno = 111, address = localhost, port = 37492
That requires a PR to land on a different repository: flutter/web_installers#26 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to make the flutter doctor new checks to pass.
Bug: #82565
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.