这是indexloc提供的服务,不要输入任何密码
Skip to content

Replace testUsingContext with testWithoutContext in a few places #82498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2021

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented May 14, 2021

Unblocked migrating device_port_forwarder_test and generate_localizations_test to null safety, so do that as well.
Part of #71511

@jmagman jmagman added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. a: null-safety Support for Dart's null safety feature labels May 14, 2021
@jmagman jmagman self-assigned this May 14, 2021
@google-cla google-cla bot added the cla: yes label May 14, 2021
@@ -22,7 +22,7 @@ import 'package:meta/meta.dart';
import 'package:test/fake.dart';

import '../src/common.dart';
import '../src/context.dart';
import '../src/fake_process_manager.dart';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

context reexports fake_process_manager, so swap the import.

@jmagman jmagman requested a review from jonahwilliams May 14, 2021 02:17
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fluttergithubbot fluttergithubbot merged commit 25c10d6 into flutter:master May 14, 2021
@jmagman jmagman deleted the testwithoutcontext branch May 14, 2021 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: null-safety Support for Dart's null safety feature c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants