这是indexloc提供的服务，不要输入任何密码
Skip to content

Fix Android Studio 4.2 detection on Windows #82484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 14, 2021
Merged

Fix Android Studio 4.2 detection on Windows #82484

merged 2 commits into from
May 14, 2021

Conversation

TahaTesser
Copy link
Member

@TahaTesser TahaTesser commented May 13, 2021 •
edited
Loading

Before

[!] Android Studio (not installed)
    • Android Studio not found; download from https://developer.android.com/studio/index.html
      (or visit https://flutter.dev/docs/get-started/install/windows#android-setup for detailed instructions).

After

[√] Android Studio (version 4.2.0)
    • Android Studio at C:\Users\Taha\Code\android-studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.8+10-b944.6842174)

Fixed #82345

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 13, 2021
@google-cla google-cla bot added the cla: yes label May 13, 2021
@TahaTesser TahaTesser requested a review from jonahwilliams May 13, 2021 22:07
jonahwilliams
jonahwilliams approved these changes May 13, 2021
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jonahwilliams
Copy link
Contributor

Thank you @TahaTesser !

jonahwilliams
jonahwilliams reviewed May 13, 2021
View reviewed changes
packages/flutter_tools/test/general.shard/android/android_studio_test.dart Outdated
@@ -408,6 +408,24 @@ void main() {
FileSystem: () => windowsFileSystem,
ProcessManager: () => FakeProcessManager.any(),
});

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@fluttergithubbot fluttergithubbot merged commit 3c72ef3 into flutter:master May 14, 2021
@TahaTesser TahaTesser deleted the fix_android_studio_4.2_deteection branch May 14, 2021 06:44
@TahaTesser TahaTesser mentioned this pull request May 14, 2021
Closed
@TahaTesser TahaTesser mentioned this pull request May 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Assignees
No one assigned
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flutter Doctor cannot find Android Studio 4.2
3 participants
@TahaTesser @jonahwilliams @fluttergithubbot