这是indexloc提供的服务，不要输入任何密码
Skip to content

Tool exit on xcodebuild -list when Xcode project is corrupted #82476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 14, 2021
Merged

Tool exit on xcodebuild -list when Xcode project is corrupted #82476

merged 2 commits into from
May 14, 2021

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented May 13, 2021 •
edited
Loading

Add corrupted Xcode project exit code 74 to the ones that should be tool exited (#40375) instead of crashing with a process exception, since this is a user configuration issue and not something the tool should handle.

Fixes #63280

@jmagman jmagman added tool Affects the "flutter" command-line tool. See also t: labels. t: xcode "xcodebuild" on iOS and general Xcode project management labels May 13, 2021
@jmagman jmagman self-assigned this May 13, 2021
@google-cla google-cla bot added the cla: yes label May 13, 2021
@jmagman jmagman changed the title Tool exit on xcodebuild -list when project is corrupted Tool exit on xcodebuild -list when Xcode project is corrupted May 13, 2021
@jmagman jmagman requested a review from jonahwilliams May 13, 2021 22:01
jonahwilliams
jonahwilliams approved these changes May 13, 2021
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit

@fluttergithubbot fluttergithubbot merged commit 8334fb0 into flutter:master May 14, 2021
@jmagman jmagman deleted the xcodebuild-list branch May 14, 2021 17:23
@jmagman jmagman added the platform-ios iOS applications specifically label Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Assignees

@jmagman jmagman

Labels
platform-ios iOS applications specifically t: xcode "xcodebuild" on iOS and general Xcode project management tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
3 participants
@jmagman @jonahwilliams @fluttergithubbot