Turn on win_build_tests_2_3 shard, skip 'build windows' tests #82386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godofredoc
approved these changes
May 12, 2021
There was a problem hiding this comment.
LGTM, fix to make VS available in bots in on review https://flutter-review.googlesource.com/c/recipes/+/13400
Oh nice, that's eminent. That one might even merge first. 😄 |
|
This pull request is not suitable for automatic merging in its current state.
|
|
build tests passed. |
godofredoc
added a commit
that referenced
this pull request
May 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-enable the shard disabled in #81955. Continue to skip the
flutter build windowstests until the right version of Visual Studio can be made available #81956.This will allow the non-Windows Android and web tests to run on this shard.
Enable only in the try builder. If this starts passing in prod I'll mark it unflaky in another PR.