Enable unnecessary_null_checks lint #82084
Conversation
|
Hello @goderbauer |
…cessary_null_checks_lint
|
See #67443 I mentioned false positives in a comment but I don't exactly remember if I fixed them. |
dev/snippets/lib/snippets.dart
Outdated
| @@ -227,6 +227,7 @@ class SnippetGenerator { | |||
| if (match != null) { // If we saw the start or end of a code block | |||
| inCodeBlock = !inCodeBlock; | |||
| if (match.namedGroup('language') != null) { | |||
| // ignore: unnecessary_null_checks | |||
There was a problem hiding this comment.
I think this means the lint is not ready yet for our code base. We don't want these ignores everywhere.
There was a problem hiding this comment.
So should I comment the lint? @goderbauer
There was a problem hiding this comment.
Actually(after checking) the lint already handle self promotion to non-null (nullable = nullable! is ok) and I think it would defeat the lint to allow any nullable = x!.
A workaround to avoid // ignore would be here:
language = match[1];
language = language!;As there's only 2 cases where this happens I tend to see this workaround as acceptable.
dev/snippets/lib/snippets.dart
Outdated
| @@ -227,6 +227,7 @@ class SnippetGenerator { | |||
| if (match != null) { // If we saw the start or end of a code block | |||
| inCodeBlock = !inCodeBlock; | |||
| if (match.namedGroup('language') != null) { | |||
| // ignore: unnecessary_null_checks | |||
There was a problem hiding this comment.
Actually(after checking) the lint already handle self promotion to non-null (nullable = nullable! is ok) and I think it would defeat the lint to allow any nullable = x!.
A workaround to avoid // ignore would be here:
language = match[1];
language = language!;As there's only 2 cases where this happens I tend to see this workaround as acceptable.
|
@Abhishek01039 could you rebase/push to trigger another build? Some current jobs seem to be stuck. |
…cessary_null_checks_lint
|
All test passed now! |
Enable unnecessary_null_checks lint
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.