Reduce potential collisions from Gold RNG #81792
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
test-exempt: part of a test I guess you could test that the format is correct. If what you're trying to do is create a unique directory on the local machine, though, why not use the createTempSync API? |
|
Gold has detected about 403 untriaged digest(s) on patchset 4. |
|
Whoops. Ok I changed something that I shouldn't have, and will most likely need to tweak further. Marking WIP in the meantime. |
|
Looks like the checks are unhappy, though. |
|
This pull request is not suitable for automatic merging in its current state.
|
|
The G testing failure is a flake. Setting to green. |
Maybe fixes #50121
Gold does not support threading, so we have a rng to randomize the directories Gold is being run out of in pre and post submit golden file testing in the framework. This currently may not be random enough. The flake reported in #50121 may be collisions caused by this.
This change tweaks the seed to not only use the clock, but also the swarming task id. Will continue monitor to see if flake persists.