-
Notifications
You must be signed in to change notification settings - Fork 28.9k
Enable Dart plugin registrant on Desktop only #81586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Dart plugin registrant on Desktop only #81586
Conversation
@blasten It looks like the presubmits are queueing indefinitely. Can you push an empty commit to give it a kick? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm on green presubmits
This pull request is not suitable for automatic merging in its current state.
|
This pull request is not suitable for automatic merging in its current state.
|
This pull request is not suitable for automatic merging in its current state.
|
@blasten This will need a re-base to get the presubmits to pass. |
This pull request is not suitable for automatic merging in its current state.
|
The regression seen in #81575 is due to looking up the plugins during hot reload (Calling
findPlugins
).I'm not sure why this is particularly bad on Web since the Android/iOS tests use the same Gallery app.
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.