这是indexloc提供的服务,不要输入任何密码
Skip to content

Enable Dart plugin registrant on Desktop only #81586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 7, 2021

Conversation

blasten
Copy link

@blasten blasten commented Apr 30, 2021

The regression seen in #81575 is due to looking up the plugins during hot reload (Calling findPlugins).

I'm not sure why this is particularly bad on Web since the Android/iOS tests use the same Gallery app.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 30, 2021
@google-cla google-cla bot added the cla: yes label Apr 30, 2021
@blasten blasten requested a review from zanderso April 30, 2021 23:41
@zanderso
Copy link
Member

zanderso commented May 3, 2021

@blasten It looks like the presubmits are queueing indefinitely. Can you push an empty commit to give it a kick?

Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm on green presubmits

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Mac build_ios_framework_module_test has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Windows build_tests_2_3 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Windows module_custom_host_app_name_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Windows tool_integration_tests_2_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Windows tool_integration_tests_2_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@zanderso
Copy link
Member

zanderso commented May 7, 2021

@blasten This will need a re-base to get the presubmits to pass.

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@blasten blasten merged commit 094179e into flutter:master May 7, 2021
@blasten blasten deleted the disable_dart_registrant_on_web branch May 7, 2021 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants