test macos binaries are codesigned before publishing #81585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to fix |
gspencergoog
approved these changes
May 1, 2021
| return; | ||
| } | ||
| // Validate that the dart binary is codesigned | ||
| final String dartPath = path.join( |
There was a problem hiding this comment.
Are there any other binaries that we should check? e.g. pub?
There was a problem hiding this comment.
i'll add a TODO, my plans are to migrate this script into //flutter/dev/tools, then it can hook into this logic to test every binary that is executable.
I tried to have this script call that one, but it was tricky, and this script is difficult to test--I was worried it would work locally but fail on LUCI when I'm actually trying to publish.
There was a problem hiding this comment.
That's a valid concern: this type of this is always hard to test without actually publishing. A TODO is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On macOS and when
--publishis provided, verify that binaries are codesigned and fail if not.fixes #81520