这是indexloc提供的服务，不要输入任何密码
Skip to content

Allow users to pass in Xcode build settings as env variables to flutter build macos FLUTTER_XCODE_ #81384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 6, 2021
Merged

Allow users to pass in Xcode build settings as env variables to flutter build macos FLUTTER_XCODE_ #81384

merged 2 commits into from
May 6, 2021

Conversation

renancaraujo
Copy link
Contributor

@renancaraujo renancaraujo commented Apr 28, 2021 •
edited
Loading

This adds the capability of specifying xcode build settings to the command "flutter build macos".

The issue with more details: #81377

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 28, 2021
@google-cla google-cla bot added the cla: yes label Apr 28, 2021
@renancaraujo renancaraujo mentioned this pull request Apr 28, 2021
Closed
@jonahwilliams jonahwilliams requested a review from jmagman April 29, 2021 20:47
jmagman
jmagman approved these changes May 4, 2021
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for doing this!

@fluttergithubbot fluttergithubbot merged commit 0bba935 into flutter:master May 6, 2021
zanderso added a commit that referenced this pull request May 7, 2021
@zanderso
Revert "Allow users to pass in Xcode build settings as env variables …
c48eb37 
…to flutter build macos FLUTTER_XCODE_ (#81384)"

This reverts commit 0bba935.
@zanderso zanderso mentioned this pull request May 7, 2021
Merged
zanderso added a commit that referenced this pull request May 7, 2021
@zanderso
Revert "Allow users to pass in Xcode build settings as env variables …
04bb954 
…to flutter build macos FLUTTER_XCODE_ (#81384)" (#82004)

This reverts commit 0bba935.
@tvolkert
Copy link
Contributor

tvolkert commented May 7, 2021

FYI, this was reverted to get the tree green again.

@jmagman jmagman mentioned this pull request May 7, 2021
Merged
@renancaraujo renancaraujo mentioned this pull request May 11, 2021
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmagman jmagman jmagman approved these changes

Assignees
No one assigned
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@renancaraujo @tvolkert @jmagman @zanderso @fluttergithubbot