-
Notifications
You must be signed in to change notification settings - Fork 28.9k
Change elevation to double of MergeableMaterial #81634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change elevation to double of MergeableMaterial #81634
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Hello @Hixie |
test-exempt: code refactor Please don't forget to update the commit message above. There's a bunch of places in this file that use "toDouble" that should now be redundant. We should remove those as well. (@a14n: might be worth a lint -- flagging cases where one has used toDouble() on a type we know statically to be a double, and similar, e.g. .round() on an int, or .toString() on a String) If this lands successfully, we should also consider doing the next one up the chain, ExpansionPanel. |
Thanks @Hixie |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, assuming the tests pass! (The Google Testing ones are the ones I'm mostly concerned about...)
Hey @Hixie |
Why the .toDouble() for the expansion tile? |
Also this probably fixes #11468 |
hello @MrBirb |
we should file a bug about ExpansionPanelList using |
Sure @Hixie |
By "we" I meant "you", really. :-) |
Great |
Update elevation from
int
todouble
Fixes #11468
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.