[flutter_tools] remove even more mocks #81618
Conversation
| @@ -189,68 +161,6 @@ void main() { | |||
| throwsA(isA<ProcessException>()), | |||
| ); | |||
| }); | |||
|
|
|||
| testWithoutContext(' flaky process fails without retry', () async { | |||
There was a problem hiding this comment.
These tests have been skipped for months, lets delete and start again another time
|
|
||
| const String xcodebuild = '/usr/bin/xcodebuild'; | ||
|
|
||
| void main() { | ||
| group('MockProcessManager', () { | ||
| mocks.MockProcessManager processManager; |
There was a problem hiding this comment.
We shouldn't be doing the timeout and restart anymore
|
|
||
| testUsingContext('Correctly performs a full refresh on attached chrome device.', () async { |
There was a problem hiding this comment.
this is testing a mock
| import '../../src/mocks.dart' show MockProcessManager, | ||
| flakyProcessFactory; |
There was a problem hiding this comment.
MockProcessManager, flakyProcessFactory, and _ProcessFactory look dead on this PR, if you'd like the joy of deleting those as well.
In fact if you move MockAndroidSdk into android_sdk_test you can delete mocks.dart totally.
There was a problem hiding this comment.
Ahh thats right, I already landed the PR that removed that usage. Will update
|
This pull request is not suitable for automatic merging in its current state.
|
|
Compile failure is wrong base PR. this is a testonly change and will not affect g3 |
Work towards #71511