这是indexloc提供的服务，不要输入任何密码
Skip to content

Migrate non_nullable to null safety #81109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2021
Merged

Migrate non_nullable to null safety #81109

merged 1 commit into from
Apr 28, 2021

Conversation

Abhishek01039
Copy link
Contributor

@Abhishek01039 Abhishek01039 commented Apr 24, 2021 •
edited
Loading

Migrated dev/integration_tests/non_nullable to null safety

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Apr 24, 2021
@google-cla google-cla bot added the cla: yes label Apr 24, 2021
@Abhishek01039
Copy link
Contributor Author

Abhishek01039 commented Apr 24, 2021 •
edited
Loading

Hello @jonahwilliams
do we need this nullable variable?
https://github.com/flutter/flutter/blob/master/dev/integration_tests/non_nullable/lib/main.dart#L7

@jonahwilliams
Copy link
Contributor

The original point of this project was to ensure that null safety worked before it was released. I think it still serves some purpose so it would be better left alone.

@Abhishek01039
Copy link
Contributor Author

Sure

@Hixie
Copy link
Contributor

Hixie commented Apr 26, 2021

test-exempt: code refactor

@Abhishek01039
Copy link
Contributor Author

Hello @jmagman
can you please review this PR?
Thanks

jmagman
jmagman approved these changes Apr 28, 2021
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linux framework_tests_misc presubmit passed.

@jmagman jmagman merged commit 677ad02 into flutter:master Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmagman jmagman jmagman approved these changes

Assignees
No one assigned
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Abhishek01039 @jonahwilliams @Hixie @jmagman