这是indexloc提供的服务,不要输入任何密码
Skip to content

Add skp_generator shard to LUCI config #81096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2021
Merged

Conversation

Hixie
Copy link
Contributor

@Hixie Hixie commented Apr 23, 2021

Fixes #80906
Depends on https://github.com/flutter/infra/pull/422

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Apr 23, 2021
@google-cla google-cla bot added the cla: yes label Apr 23, 2021
@Hixie
Copy link
Contributor Author

Hixie commented Apr 23, 2021

cc @christopherfujino

Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (pending the pre-submit passes ofc)

@Hixie
Copy link
Contributor Author

Hixie commented Apr 24, 2021

@christopherfujino clearly i did something wrong, the test isn't completing and i can't see logs...

@christopherfujino
Copy link
Contributor

The builder definitely exists: https://ci.chromium.org/p/flutter/builders/try/Linux%20skp_generator. I wonder if maybe you opened this PR before new builder had propagated to LUCI, or if cocoon (which does pre-submit scheduling) had some caching? Re-triggering the build, and I'll come back to check on Monday.

@christopherfujino
Copy link
Contributor

Oh annoying, I guess if it's "pending" you can't re-run.

@Hixie
Copy link
Contributor Author

Hixie commented Apr 24, 2021

I repushed, that should do it.

@christopherfujino
Copy link
Contributor

I repushed, that should do it.

It ran and passed. This PR looks good to go.

I looked at the timestamps, and this PR was opened 7 minutes before your infra change was merged. I'll add a special note on the wiki page that opening this framework PR before the infra change has propagated will lead to bad times.

@Hixie
Copy link
Contributor Author

Hixie commented Apr 26, 2021

Awesome, thanks!

@Hixie
Copy link
Contributor Author

Hixie commented Apr 26, 2021

Checked the logs for the test and it ran as expected. Landing.

@Hixie Hixie merged commit 4ff1734 into flutter:master Apr 26, 2021
@Hixie Hixie deleted the skp_test2 branch April 26, 2021 19:14
@Hixie
Copy link
Contributor Author

Hixie commented May 11, 2021

This was further tweaked it #82239.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a test for skp_generator in flutter/tests to flutter/flutter
2 participants