这是indexloc提供的服务，不要输入任何密码
Skip to content

Test the skp_generator. #81087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2021
Merged

Test the skp_generator. #81087

merged 1 commit into from
Apr 23, 2021

Conversation

Hixie
Copy link
Contributor

@Hixie Hixie commented Apr 23, 2021

This adds a shard to test.dart to test skp_generator in flutter/tests.

This should not run for beta and stable.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Apr 23, 2021
@google-cla google-cla bot added the cla: yes label Apr 23, 2021
@Hixie
Copy link
Contributor Author

Hixie commented Apr 23, 2021

cc @christopherfujino

christopherfujino
christopherfujino approved these changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I filed #81092 and assigned to myself to track skipping on release branches.

@Hixie Hixie merged commit 7ec7d4d into flutter:master Apr 23, 2021
@Hixie Hixie deleted the skp_test branch April 23, 2021 23:06
Hixie added a commit to Hixie/infra that referenced this pull request Apr 23, 2021
@Hixie
Add skp_generator shard to flutter/flutter
a6aaff9 
Fixes flutter/flutter#80906
Depends on flutter/flutter#81087
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherfujino christopherfujino christopherfujino approved these changes

Assignees
No one assigned
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hixie @christopherfujino