Wait for frame rendering to stabilize before running the all_elements_bench benchmark #81086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_bench benchmark Without this, rendering of the initial frames will occur after the benchmark measurement completes. This may result in shader compilation happening while the benchmark app is shutting down, which can cause crashes. See flutter#77193
This comment has been minimized.
This comment has been minimized.
dnfield
reviewed
Apr 23, 2021
Comment on lines
+46
to
+48
| for (int i = 0; i < 5; i++) { | ||
| await SchedulerBinding.instance.endOfFrame; | ||
| } |
There was a problem hiding this comment.
Are we guaranteed to get five frames?
There was a problem hiding this comment.
In test runs this appears to work. I'm not sure what would be safest here given that AFAIK there isn't a signal from the framework indicating when enough frames have rendered.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
There was a problem hiding this comment.
How about this?
Suggested change
| for (int i = 0; i < 5; i++) { | |
| await SchedulerBinding.instance.endOfFrame; | |
| } | |
| assert(SchedulerBinding.instance.hasScheduledFrame); | |
| for (int i = 0; i < 5 && SchedulerBinding.instance.hasScheduledFrame; i++) { | |
| await SchedulerBinding.instance.endOfFrame; | |
| } |
There was a problem hiding this comment.
SchedulerBinding.instance.hasScheduledFrame is false at this point in the script
There was a problem hiding this comment.
Ahh actually, looking at endOfFrame's impl, it looks like it schedules a frame if one isn't already pending. Ok. This should be fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, rendering of the initial frames will occur after the
benchmark measurement completes. This may result in shader compilation
happening while the benchmark app is shutting down, which can cause
crashes.
See #77193