Adding win devicelab bot results to dashboard. (#80974) #81077
Conversation
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
| @@ -845,6 +845,48 @@ | |||
| "repo": "flutter", | |||
| "task_name": "win_web_tool_tests", | |||
| "flaky": true | |||
| }, | |||
There was a problem hiding this comment.
Can you remove dev/devicelab/manifest.yaml as well?
|
|
||
| # iOS on-device tests | ||
|
|
||
| flutter_gallery_sksl_warmup__transition_perf_e2e_ios32: |
There was a problem hiding this comment.
There's various iOS tests missing, can you add those as well?
There was a problem hiding this comment.
I assume those are not to be run on this branch?
There was a problem hiding this comment.
They should be. These were missed from the devicelab migration
| "flaky": false | ||
| }, | ||
| { | ||
| "name": "Windows_android windows_chrome_dev_mode", |
There was a problem hiding this comment.
Did we enable these builds in flutter/infra for this branch?
There was a problem hiding this comment.
I do not know how to check that.
There was a problem hiding this comment.
Yep, the release branches copy the master builders, so this PR added these builders for all release branches: https://github.com/flutter/infra/pull/410/files
Changes to switch off agent results, which are no longer being used.
|
deleting the manifest_test.dart as well. |
|
Are the failures expected? Is this ok to merge? |
Yeah, this is good to merge. |
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.