Use "aliases" in args to fix some technical debt #81073
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The three commits may be easier to review in isolation than as one diff, they are intentionally separated. |
| @@ -59,34 +58,45 @@ const String _needHelp = 'Every option must have help explaining what it does, e | |||
| const String _header = ' Comment: '; | |||
|
|
|||
| void verifyOptions(String command, Iterable<Option> options) { | |||
| assert(command.contains('"')); | |||
| /*late*/ String target; | |||
There was a problem hiding this comment.
This actually doesn't need to be late since it is definitely assigned (I believe it could even be final)
jonahwilliams
approved these changes
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All arguments (except the "precache" ones that map to actual internal values) now follow the standard lowercase with hyphens pattern for command line arguments. Also, "uri" has been changed to "url" in various places.
Old names still work, for backwards compatibility.
Fixes #76271.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.